Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use PortalSettings to retrieve role IDs for "Registered Users" and "Administrators" #708

Merged

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

  • Use PortalSettings to get Registered Users and Administrator role IDs

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #684

@johnhenley johnhenley added the technical debt Issue that doesn't directly affect usability but will improve technical debt posture label Mar 12, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 12, 2024
@johnhenley johnhenley self-assigned this Mar 12, 2024
@johnhenley johnhenley changed the title Use PortalSettings for ENH: Use PortalSettings to retrieve role IDs for "Registered Users" and "Administrators" Mar 12, 2024
@johnhenley johnhenley merged commit 6b45d5e into DNNCommunity:dev Mar 27, 2024
1 check passed
@johnhenley johnhenley deleted the dev81/1-refactoring/9-constants-684 branch March 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASK: Replace hardcoded strings like "Administrators" with constants
1 participant