Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Show toolbar in My Settings #723

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Not a bug or huge issue, but when the "My Settings" option is selected, the Forums toolbar does not show; this is inconsistent with other views in the module. This is now working consistently with other views in the Forums module.

Changes made

  • "My Settings" was originally created like a settings page, and inherited from SettingsBase rather than ForumBase class
  • Updated various aspects of the loading of the "My Settings" control

How did you test these updates?

Before:
image

After:
image

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #686

@johnhenley johnhenley added the enhancement New feature or request label Mar 28, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 28, 2024
@johnhenley johnhenley self-assigned this Mar 28, 2024
@johnhenley johnhenley merged commit 0e2940b into DNNCommunity:dev Apr 3, 2024
1 check passed
@johnhenley johnhenley deleted the issues/toolbar-not-shown-in-my-settings-686 branch April 3, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: "My settings" should show the Forums toolbar
1 participant