-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap Theme collapse fix + quickreply alignment #790
Bootstrap Theme collapse fix + quickreply alignment #790
Conversation
@johnhenley I made a small "mistake" this mow fixes 2 issues :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timo-Breumelhof the quick reply is OK. However, the group collapse is collapsing all groups, not just the one group (I'm guessing you aren't testing with multiple groups?). I remember we talked about adding a token so you could have a target for the group being collapsed? See this screenshot from an email exchange we had to discuss using the [FORUMGROUPID] token in the href of the collapse.
” href-“#group[FORUMGROUPID]”>
@johnhenley hmm, I didn't notice that. I'll have a look |
@johnhenley |
Just put it in the href for the collapse. Don’t change the group
John
…________________________________
From: Timo Breumelhof ***@***.***>
Sent: Thursday, May 9, 2024 6:40:34 AM
To: DNNCommunity/Dnn.CommunityForums ***@***.***>
Cc: John Henley ***@***.***>; Mention ***@***.***>
Subject: Re: [DNNCommunity/Dnn.CommunityForums] Bootstrap Theme collapse fix + quickreply alignment (PR #790)
@johnhenley<https://github.com/johnhenley>
I now implemented it but the token does not seem to work inside the [GROUP]..
See:
image.png (view on web)<https://github.com/DNNCommunity/Dnn.CommunityForums/assets/8999382/be964644-8301-48d0-9660-1e3fb94f041d>
—
Reply to this email directly, view it on GitHub<#790 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACI4JZUDD2PFAPBF2RVSCYTZBNHCFAVCNFSM6AAAAABHNAVGN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGQYTIMRZGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@johnhenley with your #795 PR this should be working now, right? |
@johnhenley I'm merging so we can test and fix whatever's left |
Fixes the collapse icons for Bootstrap 5
Description of PR...
Changes made
How did you test these updates?
Local install
PR Template Checklist
Please mark which issue is solved
Close #788
Close #789