Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Theme collapse fix + quickreply alignment #790

Merged

Conversation

Timo-Breumelhof
Copy link
Contributor

@Timo-Breumelhof Timo-Breumelhof commented May 8, 2024

Fixes the collapse icons for Bootstrap 5

Description of PR...

Changes made

  • Added some attributes to the collapse elements to support Bootstrap 5
  • Fix quick reply alignment

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #788
Close #789

@Timo-Breumelhof Timo-Breumelhof added bug Something isn't working themes Dnn Community Forums Themes labels May 8, 2024
@Timo-Breumelhof Timo-Breumelhof added this to the 08.01.00 milestone May 8, 2024
@Timo-Breumelhof Timo-Breumelhof self-assigned this May 8, 2024
@Timo-Breumelhof Timo-Breumelhof changed the title Feature/788 btst5 collapse Feature/788 btst5 collapse _ quickreply alignment May 8, 2024
@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I made a small "mistake" this mow fixes 2 issues :-)

@Timo-Breumelhof Timo-Breumelhof changed the title Feature/788 btst5 collapse _ quickreply alignment Bootstrap Theme collapse fix + quickreply alignment May 8, 2024
Copy link
Collaborator

@johnhenley johnhenley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timo-Breumelhof the quick reply is OK. However, the group collapse is collapsing all groups, not just the one group (I'm guessing you aren't testing with multiple groups?). I remember we talked about adding a token so you could have a target for the group being collapsed? See this screenshot from an email exchange we had to discuss using the [FORUMGROUPID] token in the href of the collapse.

” href-“#group[FORUMGROUPID]”>

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley hmm, I didn't notice that. I'll have a look

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley
I now implemented it but the token does not seem to work inside the [GROUP]..

See:
image

@johnhenley
Copy link
Collaborator

johnhenley commented May 9, 2024 via email

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley with your #795 PR this should be working now, right?

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I'm merging so we can test and fix whatever's left

@Timo-Breumelhof Timo-Breumelhof merged commit 8f807bf into DNNCommunity:dev May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working themes Dnn Community Forums Themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: BTST Theme Quick Reply layout and alignment BUG: BTST Theme Forum Collapse not working in BTST5
2 participants