binary input format #201
Merged
binary input format #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option -B allows to read datafile formated like TCP stream with DNS messages.
|
@jelu I think this is ready for review. |
|
This is gonna take a while to review. Btw, you've missed |
- `datafile`:
- Move format to structure and set during open
- `read_one_blob()`:
- remove unused variables
- change read to be a two step, first size then wire data
- fix calc of what's in the buffer
- prefix format enums will full type name
- `dns`:
- remove `perf_dns_change_qid()`
- `dnsperf`:
- reformat man-page and add exclusivity of `-B`
- `do_send()`: use pointer to buffer to send instead of overwriting `msg`
- `resperf`: fix usage of new functions
- `test/test7`:
- fix shell code to work with generic `/bin/sh`
- fix usage in build directory
|
triggering webhooks |
|
#build |
- `datafile`: fix strict-aliasing warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to read binary input using TCP stream format (2 bytes packet length, then packet binary, repeat).
New format is used when new option -B is in use. Avoids need to reencode packets repeatedly, and allows to send nonsense packets as well.