Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import patched pcap_layers.c code with buffer overflow bugfix #21

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

wessels
Copy link
Member

@wessels wessels commented Apr 7, 2016

Debugged overflow bug in fragment processing thanks to packet capture provided by L-root.

@jelu
Copy link
Member

jelu commented Apr 7, 2016

@wessels: Are the fragments in l->frags always in the correct order?

@jelu jelu added the bug label Apr 7, 2016
@jelu jelu self-assigned this Apr 7, 2016
@wessels
Copy link
Member Author

wessels commented Apr 7, 2016

/*
 * Insert frag into list ordered by offset
 */
for (F = &l->frags; *F && ((*F)->offset < f->offset); F = &(*F)->next);
f->next = *F;
*F = f;

@jelu
Copy link
Member

jelu commented Apr 7, 2016

@wessels Thanks, didn't see that at first. So this might happen when you have a bad router or is under fragmentation attack, wound it not be interesting to do statistics about that or at least log it?

@jelu jelu merged commit 5d5adae into DNS-OARC:develop Apr 12, 2016
@jelu jelu added this to the 2.0.0rc1 milestone May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants