write last XML file on shutdown using the current timestamp #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch originally from michael.braunoeder@nic.at
|
@klaus3000 Thanks for the PRs, seeing that most of them seem to be from others are you up for correcting them if I find something or do you want me to offload the diffs? |
|
Some patches were written by my colleague. We have them in production since 5 years and I only modified them to apply to current HEAD. If you find any issues with the patches I will take care of it. I just wanted to give the credits to the original author. |
| @@ -98,6 +101,10 @@ daemonize(void) | |||
| } | |||
| if (pid > 0) | |||
| exit(0); | |||
| if (pid == 0) { | |||
There was a problem hiding this comment.
pid will always be 0 because of lines above.
... and install the signal handler after the Arena was initialized to avoid crashes when sending SIGTERM while process is waiting for a new minute to start.
|
I have moved this to #33, will look over all signal handling and why it would be needed within the loop/after arena init. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch originally from michael.braunoeder@nic.at