Add IPv6 support to country indexer #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +54,7 @@ | |||
| #endif | |||
|
|
|||
|
|
|||
| #include "config.h" | |||
There was a problem hiding this comment.
Because some lines below you have:
#if HAVE_LIBGEOIP
#include "country_index.h"
But HAVE_LIBGEOIP is defined in config.h and not yet included.
| static char *ipstr; | ||
| static char unknown[20] = "__"; | ||
| static char *unknown = "??"; |
There was a problem hiding this comment.
Changing the format for unknown IP addresses will break backwards compatibility, is it important for you to know if its an unknown v4 or v6 ?
There was a problem hiding this comment.
I think it is interesting to know. And, as config.h was not included yet, I think nobody used this feature except us. But if you like backwardscompatibility I do not mind changing it back to the old version.
|
Needs a rebase also. |
|
Going to fix and rebase this from my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.