DoH: increase temp. receive buffer size to 16K (#1) #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR increases the size of a temporary receive buffer to hold
16K - exactly one max sized TLS record. This small change ensures
flamethrower compatibility with servers employing write request
buffering (consolidation) and deployments where TLS encryption is
offloaded to third-party software (e.g. haproxy). In the latter case,
the software could employ its own write buffering technics.
I managed to hit both of these use cases. In such a case, one would see
a lot of "malformed data" messages from the flamethrower.