Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option to return NXDOMAIN response #1143

Closed
mirfatif opened this issue Jan 8, 2020 · 2 comments
Closed

[Feature Request] Add option to return NXDOMAIN response #1143

mirfatif opened this issue Jan 8, 2020 · 2 comments

Comments

@mirfatif
Copy link

mirfatif commented Jan 8, 2020

Is your feature request related to a problem?

No.

Describe the solution you'd like

In addition to refused, hinfo or IP responses, can we get NXDOMAIN with configurable TTL and SOA.MINIMUM field?

Alternatives you've considered

Ad blockers like AdGuard and others provide similar option: AdguardTeam/AdguardForAndroid#2847 (comment)

Who will that feature be useful to?

It's just mprovement.

What have you done already?

Nothing.

What are you going to contribute?

Sorry I'm not capable of that.

Additional context

@mirfatif mirfatif changed the title Add option to return NXDOMAIN response [Feature Request] Add option to return NXDOMAIN response Jan 8, 2020
@jedisct1
Copy link
Member

jedisct1 commented Jan 8, 2020

This is a bad idea.

It is perfectly valid to block example.com and not api.example.com (using whitelisting or the = prefix in the blacklist).

But returning NXDOMAIN to a query for example.com would suggests to the client that *.example.com doesn't exist. A caching resolver in front of dnscrypt-proxy would cache that information, and return NXDOMAIN for api.example.com. A 0 TTL wouldn't help much with resolvers (ex: MacOS built-in stub resolver) enforcing a minimum TTL.

@jedisct1 jedisct1 closed this as completed Jan 8, 2020
@mirfatif
Copy link
Author

mirfatif commented Jan 8, 2020

@jedisct1 alright. May be not a good idea practically, but I had to run dnsmasq just for this while doing some testing. dnsmasq --address=/example.com/ returns NXDOMAIN. Somewhat similar idea is pdnsd-ctl neg example.com ... which doesn't always block all subdomains, if I understand correctly.

@DNSCrypt DNSCrypt locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants