-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yandex #906
Update Yandex #906
Conversation
IPv6 should remain distinct entries. There's no way to select IPv6 resolvers otherwise. |
Doesn't |
Only use-case I've found for such resolvers being on distinct entries based on their IP protocol is when for example someone specifically wants to use different resolvers with different IP versions e.g.: server_names = ['yandex-ipv6', 'cloudflare'] and filtering them with |
I don't think |
I used Meganerd's entries (as they are merged). Here's what I've found during my tests: The algorithm basically selects a random stamp that belongs to a entry, when using server_names = ['meganerd'] which is a dnscrypt one, if the randomly chosen stamp matches the But with DoH the story gets to be so much more interesting, as the algo only does the random selection and doesn't respect the It's a shame, I thought I could also make You think I can open up an issue for dnscrypt-proxy and file this as an issue (or a feature request)? Or should we stick with the current template (as it's the simplest method)? |
But my honest thought about the naming schemes is that they should definitely be reconsidered. With the current one it can be quite ambiguous. A standard should be developed for naming them and get to be strictly applied. Maybe with DNSCrypt v4? I don't know how much the devs and the community are comfortable with breaking changes. |
This is the original naming scheme. Some people are still running We can certainly make the current version of But to be honest, I like the fact that IPv6 entries are distinct, and that when we use them, this is explicit. For the same resolver, performance can be very different when reached over IPv4 and IPv6, so it's also nice to have both being probed, and used as needed depending on their latency. |
BTW I'm at the SYCL conference, so I won't have much time to review/merge these PRs this week. |
I'd love to participate in its upgrades to make Regarding the conference, take your time, I'm not going anywhere. |
The Do they need something else? Maybe a different query path? Do they work at all? |
There's no mention of paths being different: https://dns.yandex.com At first I thought it has something to do with only using the IP in VHOST field (as we see with some resolvers that share the same IP on different tiers but know what to do with the query based on request's SNI); But no, that didn't do it too and I could get correct answers for adult sites again. What do you propose? Should I add them to the regular |
I would remove it, as it doesn't behave as expected. And not include it in the regular |
Done. |
No description provided.