Allow empty names in dme_record (#3) #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! What do we have to do to get this merged? I'm considering just changing DNS providers to one that better supports terraform |
|
👍 to getting this merged. I'm running into the issue that this PR addresses too and certainly by visual inspection it looks to be good |
|
Closing this PR, as provider has been redeveloped and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes Issue #3 and builds upon the existing PR #5.
I've added an acceptance test called
TestAccDMERecord_tldto confirm this is working as expected.Acceptance Test Notes
Some acceptance tests failed for me when I ran the entire suite.
TestAccDMERecordTXTTestAccDMERecordSPFTestAccDMERecordNSThese failures occurred before and after my changes. They seem unrelated and should probably be addressed in a separate PR.