fix/UNJUNS-2074: a11y - Focus après bouton "Remonter en haut de page" #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylviamoreno
force-pushed
the
fix/UNJ1S-2074-a11y-bouton-haut-de-page
branch
from
1d4e3e5
to
6d85369
Compare
| expect(linkComponent.getAttribute('href')).toEqual('https://mon-lien-externe'); | ||
| expect(linkComponent).toHaveAttribute('target'); | ||
| expect(linkComponent).toHaveAttribute('rel'); | ||
| expect(linkComponent).toHaveAttribute('href', lienExterne); |
There was a problem hiding this comment.
On veut tester la valeur pas le fait qu'on fait passer la variable, c'est un détail mais si on fait ça "proprement" il faudrait laisser 'https://mon-lien-externe'
sylviamoreno
force-pushed
the
fix/UNJ1S-2074-a11y-bouton-haut-de-page
branch
from
ac8ff05
to
7eff510
Compare
juliebrunetto83
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.