New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy in OAI-PMH #2200
Discrepancy in OAI-PMH #2200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this job is only half-done. This may fix the oai_dc article endpoint, but it does not address the oai_dc journal endpoint or the doaj formatted metadata article endpoint.
…m:DOAJ/doaj into feature/3446_oaipmh_missing_metadata_attr
metadata = etree.Element(self.PMH + "metadata", nsmap=self.NSMAP) | ||
oai_doaj_article = etree.SubElement(metadata, self.OAI_DOAJ + "doajArticle") | ||
metadata = etree.Element(self.PMH + "metadata") | ||
oai_doaj_article = etree.SubElement(metadata, self.OAI_DOAJ + "doajArticle", nsmap=self.NSMAP) | ||
oai_doaj_article.set(self.XSI + "schemaLocation", | ||
"http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd http://doaj.org/features/oai_doaj/1.0/ https://doaj.org/static/doaj/doajArticles.xsd") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richard-jones I am unsure about the schemaLocation that should be added here. Could you help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me, I think
Discrepancy in OAI-PMH
Please don't delete any sections when completing this PR template; instead enter N/A for checkboxes or sections which are not applicable, unless otherwise stated below
See 3446
The
oai_dc:dc
element in each record has missing namespace declaration when required:https://www.openarchives.org/OAI/openarchivesprotocol.html#OAIPMHschema
Categorisation
This PR...
Basic PR Checklist
constants
ormessages
filesdates
)develop
develop
(or other base branch)Testing
To confirm this works locally, go to:
http://localhost:5004/oai.article?verb=ListRecords&set=TENDOkRlcm1hdG9sb2d5&from=2022-08-31T23%3A00%3A00Z&metadataPrefix=oai_dc
and confirm that the element
oai:dc
(in metadata for each record) has all the required attributes. Just so you know, some browsers hide that information in the default view - opening the inspector in developers console may be required.Deployment
What deployment considerations are there? (delete any sections you don't need)
Configuration changes
What configuration changes are included in this PR, and do we need to set specific values for production
Scripts
What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).
Migrations
What migrations need to be run to deploy this
Monitoring
What additional monitoring is required of the application as a result of this feature
New Infrastructure
What new infrastructure does this PR require (e.g. new services that need to run on the back-end).
Continuous Integration
What CI changes are required for this