Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing use of ::select in favor of ::poll #1044

Conversation

johnjanthony
Copy link
Contributor

Replacing use of ::select() with ::poll() in SSL_SOCK_Connector and SSL_SOCK_Acceptor - on systems that support ::poll(). This is primarily to allow for more than 1024 connections.

Replacing use of ::select() with ::poll() in SSL_SOCK_Connector and SSL_SOCK_Acceptor - on systems that support ::poll()
@shuston
Copy link
Contributor

shuston commented Feb 21, 2020

These changes look good to me.

@shuston
Copy link
Contributor

shuston commented Feb 21, 2020

John - note that there was a fuzz check failure:
Running tabs check
Error: ./ACE/ace/SSL/SSL_SOCK_Connector.cpp:79: found tab
Error: ./ACE/ace/SSL/SSL_SOCK_Connector.cpp:80: found tab
Error: ./ACE/ace/SSL/SSL_SOCK_Connector.cpp:81: found tab
Error: ./ACE/ace/SSL/SSL_SOCK_Acceptor.cpp:74: found tab
Error: ./ACE/ace/SSL/SSL_SOCK_Acceptor.cpp:75: found tab
Error: ./ACE/ace/SSL/SSL_SOCK_Acceptor.cpp:76: found tab

Please replace the tabs with spaces and push the change on the same branch.

@johnjanthony
Copy link
Contributor Author

Tabs removed. Sorry for the delay in responding, I was loosing GitHub notifications -

@johnjanthony
Copy link
Contributor Author

trailing spaces removed

@jwillemsen jwillemsen added the needs review Needs to be reviewed label May 22, 2020
@jwillemsen
Copy link
Member

@shuston shuston merged commit 885ffbb into DOCGroup:master Jun 29, 2020
@jwillemsen
Copy link
Member

@shuston @johnjanthony as the bugzilla issue suggests, wouldn't this change be easier when using ACE::handle_ready which handles the select/poll selection?

@jwillemsen
Copy link
Member

jwillemsen commented Jun 29, 2020

In #1145 I changed the flags of ACE::handle_ready to be bool instead of int

@jwillemsen jwillemsen added this to the 6.5.10/2.5.10 milestone Jun 29, 2020
@shuston
Copy link
Contributor

shuston commented Jun 29, 2020

It would be easier, I agree. I don't have funding or spare time to work on it.
Also, side note... since the ACE_handle_ready API changed, would this need to be in a 6.6.0?

@jwillemsen
Copy link
Member

We are reverting this PR for the moment, see #1146, it has to be improved to keep the code clean, see #1147 for the links to related issues and suggestions to keep this code clean. @johnjanthony can you work on a new PR with the clean changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs to be reviewed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants