New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing use of ::select in favor of ::poll #1044
Replacing use of ::select in favor of ::poll #1044
Conversation
Replacing use of ::select() with ::poll() in SSL_SOCK_Connector and SSL_SOCK_Acceptor - on systems that support ::poll()
These changes look good to me. |
John - note that there was a fuzz check failure: Please replace the tabs with spaces and push the change on the same branch. |
Tabs removed. Sorry for the delay in responding, I was loosing GitHub notifications - |
trailing spaces removed |
Maybe related http://bugzilla.dre.vanderbilt.edu/show_bug.cgi?id=3604 |
@shuston @johnjanthony as the bugzilla issue suggests, wouldn't this change be easier when using ACE::handle_ready which handles the select/poll selection? |
In #1145 I changed the flags of ACE::handle_ready to be bool instead of int |
It would be easier, I agree. I don't have funding or spare time to work on it. |
We are reverting this PR for the moment, see #1146, it has to be improved to keep the code clean, see #1147 for the links to related issues and suggestions to keep this code clean. @johnjanthony can you work on a new PR with the clean changes? |
Replacing use of ::select() with ::poll() in SSL_SOCK_Connector and SSL_SOCK_Acceptor - on systems that support ::poll(). This is primarily to allow for more than 1024 connections.