Minor Additions to IDL4 Support #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
force-pushed
the
igtd/small-idl4-features
branch
from
9df4eb9
to
75650bc
Compare
- Support the following IDL v4 features:
- Empty structs
- `octet` and `wchar` union discriminators
- Allow using empty parentheses in annotation applications to
workaround syntax errors when an annotation with no arguments has to
be followed by a complete scoped name:
`@example_annotation() ::ex::ExampleType`
- Reserve the `bitfield`, `bitmask`, and `bitset` keywords in IDL v4
(these are not implemented yet)
- Allow using `map` as an identifier in IDL v3 again
iguessthislldo
force-pushed
the
igtd/small-idl4-features
branch
from
75650bc
to
f78f458
Compare
iguessthislldo
changed the title
jwillemsen
reviewed
Jun 10, 2024
jwillemsen
reviewed
Jun 10, 2024
jwillemsen
reviewed
Jun 10, 2024
jwillemsen
reviewed
Jun 10, 2024
jwillemsen
reviewed
Jun 10, 2024
mitza-oci
previously approved these changes
Jun 10, 2024
mitza-oci
approved these changes
Jun 11, 2024
jwillemsen
approved these changes
Jun 12, 2024
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Jun 13, 2024
DOCGroup/ACE_TAO#2244 sets `TAO_IDL_HAS_OCTET_AND_WCHAR_UNION_DISCS` to 1, but the char_literals wchar union contains all the escape sequences literals, which are not supported in TAO_IDL: DOCGroup/ACE_TAO#1284. This changes it to check the planned macro name. Also removed the hex and octet escape sequences for wchar, which are probably not indented to work with wchar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octetandwcharunion discriminators (Fixes IDL4 union discriminator extension #1255)typedefs ofint8anduint8as union discriminatorsworkaround syntax errors when an annotation with no arguments has to
be followed by a complete scoped name:
@example_annotation() ::ex::ExampleTypebitfield,bitmask, andbitsetkeywords in IDL v4(these are not implemented yet) (Fixes IDL4 keyword escaping needs to be extended with the new keywords #1256)
mapas an identifier in IDL v3 again