BZ-4216 Android build fails when not cross-compiled on Linux #279
Conversation
[Changed] platform_android.GNU - replace the platform_linux_common.GNU include with its contents except the erroneous call to getconf [Tests] Test 1: 1) Compile ACE for Android using OSX or Windows 2) Verify build is successful
| @@ -9,7 +9,123 @@ no_hidden_visibility ?= 1 | |||
| # as of NDK r6 inlining is required | |||
| inline ?= 1 | |||
|
|
|||
| include $(ACE_ROOT)/include/makeinclude/platform_linux_common.GNU | |||
| # start of: include most of platform_linux_common.GNU | |||
There was a problem hiding this comment.
No need for this comment to my idea, we have git history to know where changes are coming from
There was a problem hiding this comment.
Fair enough. I added this for my project but wasn't sure if it was needed in the master repo. I'll remove it in my next update when this round of the review is complete.
|
Probably more contents taken from the original file doesn't apply to android, but can imagine it is hard to sort that out |
|
Agreed that we most likely don't need a lot of the content. I decided to leave it so I don't accidentally break something. I'm not an expert on compiler flags. Please let me know when you have finished the review and I will upload my latest changes. |
|
I will not be able to review further at this moment, please upload your latest changes, maybe someone else can review further |
|
@dlifshitz-maca can you commit and push your improvements? |
|
@jwillemsen Yes, I will put it on my list for next week. Thanks for the reminder. |
[Changed] platform_android.GNU - removed extra comment and include
[Changed]
platform_android.GNU
except the erroneous call to getconf
[Tests]
Test 1: