Issue 139 (partial): Fix DASH shape-component usage by copying original shape #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shape-component transcribed from DASH was transcribed incorrectly. The RDF List was constructed incorrectly, needing both a `rdf:first` and `rdf:rest` predicate. Also, from DASH-prescribed usage with `sh:or`, the RDF List members must be `sh:Shape`s, each housing a `sh:datatype` constraint predicate. To avoid other transcription or reformatting errors, this patch copies the original shape from DASH, adding an `rdfs:isDefinedBy` to cite the source. Because DASH does not provide a `owl:versionIRI`, an extra comment noting the copy date and destination file is also added. This patch addresses 37 of the 70 reported SHACL-SHACL validation errors noted in Issue 139. References: * https://datashapes.org/dash.html#StringOrLangString * DOI-DO#139 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This merge aligns some whitespace styling by hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch(es) in this PR include documentation for their changes.
This PR fixes some, but not all, of the SHACL-SHACL validation issues in #139 . It includes a suggestion for how to fix some of the other issues pertaining to the
sh:or-linkedrdf:Lists. I'm happy to add follow-on patches to fix otherrdf:Listissues, but I wanted to pause for input from the maintainers before doing so.I believe this PR can be merged without negative impact.