Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSM Translation File - Not PVL Compliant? #5484

Closed
jlaura opened this issue Apr 24, 2024 · 2 comments · Fixed by #5561
Closed

CSM Translation File - Not PVL Compliant? #5484

jlaura opened this issue Apr 24, 2024 · 2 comments · Fixed by #5561
Assignees
Labels
bug Something isn't working

Comments

@jlaura
Copy link
Collaborator

jlaura commented Apr 24, 2024

ISIS version(s) affected: 8.0.0+

Description

The CSM serial number translation file is not parsable by other PVL libraries. As noted in this issue on the planetarypy PVL library, this PVL is not compliant with a PVL specification.

Can this PVL be made compliant and maintain the same functionality? In order to make this work in the PVL library, "Group" inside the Group = /End_Group was quoted and the bare Auto keyword (??) was removed.

Here is the ISIS PVL file:

InputGroup = "IsisCube,CsmInfo"

How to reproduce
This reproduces in an external library, so maybe this is behaving as intended. I hope not, because libraries like plio make use of these translation tables and need a mechanism to convert them into JSON. Right now, the PVL library is that means.

Possible Solution

Additional context

@jlaura jlaura added the bug Something isn't working label Apr 24, 2024
@acpaquette
Copy link
Collaborator

Bumping this, after further discussion on the planeterypy issue the unquoted Group as a value is an issue in the planeterypy/pvl library but the bare Auto keyword is an ISIS issue and is non-compliant PVL.

A fairly easy fix is to make the Auto keyword have a boolean value, so all groups in translation files will have an Auto keyword with a value of 0|1. So it will look something like Auto=0|1

@jlaura
Copy link
Collaborator Author

jlaura commented Apr 25, 2024

@acpaquette Thanks for the discussion over there. Transitioning from Auto to Auto=0|1 sounds like a solid plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants