Topds4 #4246
Merged
Topds4 #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed compile and deprication warnings. Fixes #4110 * temp add of to pds 4 test * Inintal topds4 app and cmake updates to include inja * Delete extra headers * Fixed inja include Co-authored-by: ssides <ssides@usgs.gov>
* Pvl to JSON conversion * Renamed file * Added repeated elements and examples
* now has some real parameters * removed inja files
* now has some real parameters * removed inja files * full orex xml * add full orex template
* Inintal topds4 app and cmake updates to include inja * Delete extra headers * Fixed inja include * Added basic working XMLToJson functionality * Updated to work with many nested levels of different amounts of repeated tags * Add support for unsupported xml edge cases * Add tests that work to test mutliple nested repeated values conversion * cleanup * Update to include no-text value cases to work in repeated-value cases * Update test * Break up tests * Fix typoes in comments
* Removed data source args and added app log * Added simple tests for topds4 * Moved line
* now has some real parameters * removed inja files * full orex xml * add full orex template * More template elements, and file size callback
* Added extra parameters * Added duplicate warnings * Fixed warning
* Basic cubeatt conversion * Add more useful function signature * Removed hardcoded path * Update based on feedback * Add better band test * Updated to fix failing tests and remove old testfiles
* Fixed callbacks and doc updates * added some extra docs
…t directly (#4244) * Update cubeatt to add cubeattributeinput option. Also add tests for all function signatures available * Remove unnecessary comments * Update to use explicit array conversion. * Remove commented out code
|
This is a draft as we still need a CHANGELOG entry. Gotta advertise our shiny new program. |
Removed temporary file
Remove temporary file
Remove temp file
kberryUSGS
reviewed
Jan 11, 2021
kberryUSGS
reviewed
Jan 11, 2021
kberryUSGS
reviewed
Jan 11, 2021
kberryUSGS
reviewed
Jan 11, 2021
scsides
approved these changes
Jan 11, 2021
scsides
previously approved these changes
Jan 11, 2021
kberryUSGS
reviewed
Jan 11, 2021
kberryUSGS
previously approved these changes
Jan 11, 2021
kberryUSGS
approved these changes
Jan 12, 2021
scsides
approved these changes
Jan 12, 2021
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new application to render PDS4 labels and an output cube for archiving. The app uses the Inja templating engine to render the output label file using data from the cube and other sources specified by the user. We also converted the cubeatt program to a callable and all of its tests so that we could use it inside of the new topds4 program. Included in this PR are tools to convert PVL and XML data to JSON as that is the data format Inja uses.
Related Issue
PDS4 templating project
Motivation and Context
The current export programs use a mixture of translation tables and hard-coded logic. This new system puts all of the work into the template file and allows for greater user flexibility without having to make code changes.
How Has This Been Tested?
Tested on an independent branch in Jenkins and locally on Ubuntu and MacOS 14.
All new code also has tests that cover the full extent of their functionality.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: