for fixStrings, add editor and workspace in fixTableStrings #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixStrings silently fails if a feature class participates in a topology class, that feature class is just skipped entirely and no error messages are thrown. Additionally, the tool can't update feature classes with active attribute rules as mentioned in the ReadMe.
After some research, it looks like you need to wrap the UpdateCursor in an Editor Session.
See the following:
attribute rule error on update cursor
Objects in this class cannot be updated outside an edit session
Note for that second link, I did not actually see the error, but it does specifically state that feature classes in a topology cannot be edited unless they are in an edit session.
So, I made a couple small changes to add an Editor to the script and tested it both with a feature class that participates in topology as well as one that had active attribute rules and the script works. Note that I did not change anything in the ReadMe about the limitation with attribute rules. It's probably worth more extensive testing before knowing for sure it was fixed.