Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced instances of 3D Analyst with equivalent Spatial Analyst function #96

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

vlatane-va-energy
Copy link
Contributor

The 3D Analyst-dependent methods in this tool are also offered in the Spatial Analyst extension. Although both are add-ons to ArcGIS, our assumption is that Spatial Analyst is more commonly used because of its utility for many traditional 2d map geoprocessing processes.

Here's a comparison matrix for the methods in both extensions.

Method 3D Help Page Spatial Help Page
AddSurfaceInformation Add Surface Information (3D Analyst) Add Surface Information (Spatial Analyst)
InterpolateShape Interpolate Shape (3D Analyst) Interpolate Shape (Spatial Analyst)

Help pages for Interpolate Shape in particular look identical! Based on the Spatial Analyst extension's update history, I assume these tools were present only in the 3D analyst extension when the original GeMS_ProjectCrossSectionData.py was written, and were later added to Spatial Analyst.

We did some minor testing and produced identical results between 3D and Spatial versions. We did not test every scenario as the Esri methods seem to be identical.

@ethoms-usgs ethoms-usgs merged commit c282dc7 into DOI-USGS:master Jan 11, 2024
@vlatane-va-energy vlatane-va-energy deleted the proposed-pull-requests branch January 11, 2024 18:33
@vlatane-va-energy vlatane-va-energy restored the proposed-pull-requests branch January 11, 2024 18:33
@vlatane-va-energy vlatane-va-energy deleted the proposed-pull-requests branch January 11, 2024 18:33
@vlatane-va-energy
Copy link
Contributor Author

@ethoms-usgs Circling back to this to let you know the line replacements in this pull request should be arcpy.sa not arcpy.da. Sorry for the typo in here - this is meant to pull from Spatial Analyst, not Data Management. Should only affect a couple of lines (see pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants