bugfix(sourcedata) had to disable nan-ing botm where botm>=(top-min_t… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hickness). Was causing layers at min thickness to not be inactivated for MF6
…es so that top and botm elevations that are reset to test sfrmaker layer assignments persist
Codecov Report
@@ Coverage Diff @@
## develop #19 +/- ##
========================================
Coverage 84.82% 84.82%
========================================
Files 55 55
Lines 10178 10182 +4
========================================
+ Hits 8633 8637 +4
Misses 1545 1545
Continue to review full report at Codecov.
|
aleaf
added a commit
that referenced
this pull request
Feb 9, 2021
#19) * bugfix(sourcedata) had to disable nan-ing botm where botm>=(top-min_thickness). Was causing layers at min thickness to not be inactivated for MF6 * fix(test_mf6_shellmound.test_idomain_above_sfr): reset cached top files so that top and botm elevations that are reset to test sfrmaker layer assignments persist Co-authored-by: Mike Fienen <mnfienen@ugss.gov> Co-authored-by: aleaf <andrew.t.leaf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hickness). Was causing layers at min thickness to not be inactivated for MF6
@aleaf some tests are failing but seem unrelated to this change.