Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tmr.py): ~40% performance improvement for Tmr.get_boundary_f… #46

Merged
merged 1 commit into from
May 5, 2022

Conversation

aleaf
Copy link
Collaborator

@aleaf aleaf commented May 5, 2022

…luxes

  • move get_intercell_connections to grid module, and seperate from flow reading so it only has to be done once
  • commented out extra intantiation of Interpolator (both x and y fluxes now interpolate to the same grid)
  • profiled get_qx_qy_qz; reading the flows from the cell budget file takes up almost all of the execution time, so further reduction would require changes to the flopy binary grid reader
  • current configuration took ~45 minutes to get boundary fluxes for the delta model (605 x 270; 21 layers)

…luxes

* move get_intercell_connections to grid module, and seperate from flow reading so it only has to be done once
* commented out extra intantiation of Interpolator (both x and y fluxes now interpolate to the same grid)
* profiled get_qx_qy_qz; reading the flows from the cell budget file takes up almost all of the execution time, so further reduction would require changes to the flopy binary grid reader
* current configuration took ~45 minutes to get boundary fluxes for the delta model (605 x 270; 21 layers)
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #46 (2d56ad2) into develop (f8e6d65) will increase coverage by 0.01%.
The diff coverage is 93.27%.

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    89.38%   89.39%   +0.01%     
===========================================
  Files           64       64              
  Lines        11764    11826      +62     
===========================================
+ Hits         10515    10572      +57     
- Misses        1249     1254       +5     
Impacted Files Coverage Δ
mfsetup/tests/test_tmr.py 95.91% <ø> (ø)
mfsetup/grid.py 87.28% <89.83%> (+0.32%) ⬆️
mfsetup/tmr.py 93.75% <93.10%> (-0.10%) ⬇️
mfsetup/fileio.py 86.34% <100.00%> (+0.10%) ⬆️
mfsetup/tests/test_grid.py 99.04% <100.00%> (+0.08%) ⬆️
mfsetup/tests/test_mf6_shellmound.py 93.38% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e6d65...2d56ad2. Read the comment docs.

@aleaf aleaf merged commit 85cc44e into DOI-USGS:develop May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants