Fixed shared field names between measures and points #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaura
reviewed
Jun 19, 2019
| # Some point and measure fields have the same name, so mangle them as point_ and measure_ | ||
| point_cols = [self.point_field_map[attr] if attr in self.point_field_map else attr for attr in self.point_attrs] | ||
| measure_cols = [self.measure_field_map[attr] if attr in self.measure_field_map else attr for attr in self.measure_attrs] | ||
| cols = point_cols + measure_cols |
jlaura
approved these changes
Jun 19, 2019
|
This is going to have knock on effects in autocnet. So once this is merged, hold off on updating! |
|
I'm not sure why coveralls is complaining about the coverage going down. I didn't modify the constructor property at all. |
|
@jessemapel Are we good to merge this? If so, anyone can do it. Reviewed and code looks good. |
|
@jlaura I want to wait until https://github.com/USGS-Astrogeology/autocnet/pull/349 is finished because this will break that. |
Kelvinrr
pushed a commit
to Kelvinrr/plio
that referenced
this pull request
May 26, 2022
* First pass at shared field names * Removed write changes * Removed print * Added better testing. Fixed weird choosername problem
ladoramkershner
pushed a commit
to ladoramkershner/plio
that referenced
this pull request
Jun 7, 2022
* First pass at shared field names * Removed write changes * Removed print * Added better testing. Fixed weird choosername problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared field names between measures and points are now called
measure_andpoint_Until #121 is fixed, I have removed the changes to the
to_isismethod.