Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TC1 #129

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Adds TC1 #129

merged 1 commit into from
Jul 25, 2019

Conversation

jlaura
Copy link
Collaborator

@jlaura jlaura commented Jul 19, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.907% when pulling 060ef5e on jlaura:master into d44cb4c on USGS-Astrogeology:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.907% when pulling 060ef5e on jlaura:master into d44cb4c on USGS-Astrogeology:master.

@ladoramkershner
Copy link
Contributor

I visualized the data.db and I noticed that the new TC1 binary has a lot of new lines and I am concerned this will cause issues. For example, TC 2 looks like

('kaguya', 'Tc2', '{"Keyword1":{"InputGroup":"IsisCube,Instrument","InputKey":"SpacecraftName","InputPosition":["IsisCube","Instrument"],"OutputName":"Keyword1","Output ... (364 characters truncated) ... on":["IsisCube","Instrument"],"OutputName":"Keyword3","OutputPosition":["Group","SerialNumberKeywords"],"Translation":["*","*"]},"ObservationKeys":3}')

while TC1 looks like

('kaguya', 'Tc1', '{\n    "Keyword1": {\n        "InputGroup": "IsisCube,Instrument",\n        "InputKey": "SpacecraftName",\n        "InputPosition": [\n            "I ... (954 characters truncated) ...     "SerialNumberKeywords"\n        ],\n        "Translation": [\n            "*",\n            "*"\n        ]\n    },\n    "ObservationKeys": 3\n}\n')

I have tried running this on the kaguya subset I have and nothing was uploaded to the database. Most of the images I am using are TC2, but I do have a few TC1 images. However, I was able to get the images at least uploaded to the database before this update.

@jlaura
Copy link
Collaborator Author

jlaura commented Jul 22, 2019

Are you able to run the generate_isis_serial func using this PR? If so, it works. If not, what is the error?

@ladoramkershner
Copy link
Contributor

I will check, my conda ate crap so I had to reinstall and remake my environment and it is a real big pain, but I am on it!!

@jlaura
Copy link
Collaborator Author

jlaura commented Jul 25, 2019

I just tested this manually using TC1 and TC2 data. Here are the results. Given that this is functioning well locally, I am going to merge.

In [1]: from plio.io.isis_serial_number import generate_serial_number

In [2]: generate_serial_number('/Users/jlaura/Desktop/TC1S2B0_01_03021N353E0029.cub')
Out[2]: 'KAGUYA/TC1/2008-06-12T18:06:33.054878'

In [3]: generate_serial_number('/Users/jlaura/Desktop/TC2S2B0_01_03528N373E3530.cub')
Out[3]: 'KAGUYA/TC2/2008-07-24T09:46:43.645082'

@jlaura jlaura merged commit 3f1e749 into DOI-USGS:master Jul 25, 2019
Kelvinrr pushed a commit to Kelvinrr/plio that referenced this pull request May 26, 2022
ladoramkershner pushed a commit to ladoramkershner/plio that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants