Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 126 and PVL grammar issue #167

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Conversation

jlaura
Copy link
Collaborator

@jlaura jlaura commented Nov 12, 2021

Adds a warning to to_isis when a target name is not passed. This also pins PVL to >= 1.3.0 as per this issue.

@jlaura jlaura requested review from ladoramkershner and removed request for ladoramkershner November 12, 2021 12:19
@ladoramkershner ladoramkershner merged commit e03d75f into DOI-USGS:master Nov 12, 2021
Kelvinrr pushed a commit to Kelvinrr/plio that referenced this pull request May 26, 2022
* Fixes 126 and PVL grammar issue

* Adds changelog.md

* Updates meta.yml for pvl version
Kelvinrr pushed a commit that referenced this pull request May 31, 2022
* Fixes 126 and PVL grammar issue

* Adds changelog.md

* Updates meta.yml for pvl version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No warning/error if no targetname passed to to_controlnetwork
2 participants