Quartair stratigrafie #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quartair_stratigrafie
added 2 commits
February 15, 2019 12:35
Roel
requested changes
Feb 15, 2019
There was a problem hiding this comment.
'Quartairstratigrafie' is the better term, so I suggest changing it everywhere (except the WFS service name). I have added some inline comments for this, but they are by no means exhaustive.
Some documentation remarks:
- can you add a link to the notebook in docs/tutorials.rst
- can you add the default dataframe output to docs/performance.rst (since df_format is to be removed in time)
change to suggestion by roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following comments by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following suggestion by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following suggestion by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following suggestion by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following correction by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
following suggestion by Roel Co-Authored-By: pjhaest <geo.haest@gmail.com>
|
in progress - not complete yet |
Roel
approved these changes
May 13, 2019
This reverts commit 396a344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTINGdocumentDescribe your fixes/additions/changes
Type of QuartaireStratigrafie added