Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property name replacement in sort_by. #391

Merged
merged 3 commits into from Aug 1, 2023
Merged

Fix property name replacement in sort_by. #391

merged 3 commits into from Aug 1, 2023

Conversation

Roel
Copy link
Member

@Roel Roel commented Jul 27, 2023

  • I have read and followed the guidelines in the CONTRIBUTING document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR fixes property name replacement in the sort_by clause of a search query. It also refactors the test fixtures to function scope (instead of module scope) to be able to expose the problem in tests.

Closes #390

@Roel Roel added this to the 3.1.0 milestone Jul 27, 2023
@Roel Roel linked an issue Jul 27, 2023 that may be closed by this pull request
sort_by is broken for fields named differently between pydov and WFS #390
Closed
@Roel Roel merged commit 24960cf into master Aug 1, 2023
40 checks passed
@Roel Roel deleted the fix-sort-by branch August 25, 2023 13:48
@Roel Roel mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

sort_by is broken for fields named differently between pydov and WFS
1 participant
@Roel