Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRUNCATE128 missing on p13 #77

Closed
defeo opened this issue Apr 8, 2020 · 6 comments
Closed

TRUNCATE128 missing on p13 #77

defeo opened this issue Apr 8, 2020 · 6 comments
Labels
protocol Questions about the protocol/cryptography

Comments

@defeo
Copy link

defeo commented Apr 8, 2020

On p13, it is said that

TRUNCATE128( H( H( seed​ t​ ) || t) )

is inserted in the Cuckoo filter, however I guess the intention was to put

TRUNCATE128( H( TRUNCATE128 ( H( seed​ t​ ) ) || t) )

(not sure about the outermost TRUNCATE128)
@lbarman lbarman added the protocol Questions about the protocol/cryptography label Apr 8, 2020
@cascremers
Copy link
Collaborator

cascremers commented Apr 9, 2020 •
edited

This is a typo -- we will fix this asap. It should be:

H( TRUNCATE128( H( seed​_t​ ) ) || t )

I.e., it is the hashed identity H(EphID || t) where EphID = TRUNCATE128( H( seed​_t​ ) ) .

@defeo
Copy link
Author

defeo commented Apr 9, 2020

You're welcome.

@cascremers
Copy link
Collaborator

Thank you!

@cascremers cascremers mentioned this issue Apr 9, 2020
Closed
@dirkx
Copy link

dirkx commented Apr 9, 2020 •
edited

thanks ! I've taken the liberty to make a fix dirkx@e47572e and put a PDF with that there too: dirkx@e47572e#diff-65ae5584dd5da0b636fb24996aa9f37d

dirkx added a commit to dirkx/DP-3T-Documents that referenced this issue Apr 9, 2020
@dirkx
Fix as per issue DP-3T#77
e47572e
@cascremers
Copy link
Collaborator

This is fixed now in the new version of the whitepaper, thanks!

Closing this issue as fixed.

@dirkx
Copy link

dirkx commented Apr 10, 2020

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Questions about the protocol/cryptography
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dirkx @defeo @cascremers @lbarman