Versions updated & reorganization #143
Conversation
iCesofT
commented
Jun 6, 2020
iCesofT
commented
- Spring boot to 2.2.7.RELEASE
- Reorganization (dependencyManagement vs dependencies)
- Spring boot to 2.2.7.RELEASE - Reorganization (dependencyManagement vs dependencies)
- We allow to use a DB access without admin privileges from the application (using `datasource.flyway.load=false` or `DATASOURCE_FLYWAY_LOAD` environment variable set-up to false). We create a Flyway @bean that do not do anything (it doesn't migrate). - We propose an application.yaml inside Docker with environment variables (see `dpppt-backend-sdk-ws/src/main/docker/application.yaml`).
|
Hi |
- PostgreSQL => XML External Entity (XXE) Injections - SnakeYAML => DoS => CVE-2003-1564.
|
I already changed my code to use logback (using spring-boot-starter-logging). |
| @@ -1,30 +1,13 @@ | |||
| <!-- Issue templates and Contributing guides are taken from the fastlane repository and adjusted for our needs (https://github.com/fastlane/fastlane/tree/master/.github/ISSUE_TEMPLATE) and --> | |||
There was a problem hiding this comment.
The and at the end of the sentence looks like a stray/artifact. Or got something lost while copy-editing?
| <!-- Issue templates and Contributing guides are taken from the fastlane repository and adjusted for our needs (https://github.com/fastlane/fastlane/tree/master/.github/ISSUE_TEMPLATE) and --> | |
| <!-- Issue templates and Contributing guides are taken from the fastlane repository (https://github.com/fastlane/fastlane/tree/master/.github/ISSUE_TEMPLATE) and adjusted for our needs --> |
From a readability perspective, I think would be better to place the URL directly to where the repository is mentioned - but that is personal preference.
| /* | ||
| * Created by Ubique Innovation AG | ||
| * https://www.ubique.ch | ||
| * Copyright (c) 2020. All rights reserved. |
There was a problem hiding this comment.
Nitpick//Observation/Question: All rights reserved. Is this an outdated copyright headers?
#75 looks like it replaced the All rights reserved. with MPL-2.0
https://github.com/DP-3T/dp3t-sdk-backend/pull/75/files
(This applies to other files of this PR, but I only make one comment - maybe there is a good reason for this header)
...ckend-sdk/dpppt-backend-sdk-ws/src/main/java/org/dpppt/backend/sdk/ws/security/KeyVault.java
Outdated
Show resolved
Hide resolved
…/backend/sdk/ws/security/KeyVault.java You are right. It is a mistake. Co-authored-by: Michael Frey <michael.frey@gmx.ch>
|
Hi - I'm an external contributor, so my comments do not reflect Ubique's team...
|
|
I will create a new PR. |
