Skip to content

Commit

Permalink
cryptodev: expose driver interface as internal
Browse files Browse the repository at this point in the history
The rte_cryptodev_pmd.* files are for drivers only and should be
private to DPDK, and not installed for app use.

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  • Loading branch information
Akhil Goyal committed Sep 8, 2021
1 parent 74645f6 commit af66803
Show file tree
Hide file tree
Showing 64 changed files with 105 additions and 79 deletions.
3 changes: 0 additions & 3 deletions doc/guides/rel_notes/deprecation.rst
Expand Up @@ -223,9 +223,6 @@ Deprecation Notices
session and the private data of session. An opaque pointer can be exposed
directly to application which can be attached to the ``rte_crypto_op``.

* cryptodev: The interface between library and drivers will be marked
as internal in DPDK 21.11.

* security: Hide structure ``rte_security_session`` and expose an opaque
pointer for the private data to the application which can be attached
to the packet while enqueuing.
Expand Down
4 changes: 4 additions & 0 deletions doc/guides/rel_notes/release_21_11.rst
Expand Up @@ -106,6 +106,10 @@ API Changes
rte_cryptodev_is_valid_dev as it can be used by the application as
well as PMD to check whether the device is valid or not.

* cryptodev: The rte_cryptodev_pmd.* files are renamed as cryptodev_pmd.*
as it is for drivers only and should be private to DPDK, and not
installed for app use.


ABI Changes
-----------
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
Expand Up @@ -5,7 +5,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
#include <rte_cpuflags.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
Expand Up @@ -6,7 +6,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "aesni_gcm_pmd_private.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
#include <rte_cpuflags.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
Expand Up @@ -8,7 +8,7 @@
#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_ether.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "aesni_mb_pmd_private.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/armv8/rte_armv8_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
#include <rte_cpuflags.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/armv8/rte_armv8_pmd_ops.c
Expand Up @@ -6,7 +6,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "armv8_pmd_private.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/bcmfs/bcmfs_sym_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_dev.h>
#include <rte_errno.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "bcmfs_device.h"
#include "bcmfs_logs.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/bcmfs/bcmfs_sym_session.h
Expand Up @@ -8,7 +8,7 @@

#include <stdbool.h>
#include <rte_crypto.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "bcmfs_sym_defs.h"
#include "bcmfs_sym_req.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/caam_jr/caam_jr.c
Expand Up @@ -9,7 +9,7 @@

#include <rte_byteorder.h>
#include <rte_common.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_crypto.h>
#include <rte_cryptodev.h>
#include <rte_bus_vdev.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/ccp/ccp_crypto.c
Expand Up @@ -20,7 +20,7 @@
#include <rte_memory.h>
#include <rte_spinlock.h>
#include <rte_string_fns.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "ccp_dev.h"
#include "ccp_crypto.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/ccp/ccp_pmd_ops.c
Expand Up @@ -5,7 +5,7 @@
#include <string.h>

#include <rte_common.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_malloc.h>

#include "ccp_pmd_private.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/ccp/rte_ccp_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_bus_vdev.h>
#include <rte_common.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_pci.h>
#include <rte_dev.h>
#include <rte_malloc.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn10k_cryptodev.c
Expand Up @@ -6,7 +6,7 @@
#include <rte_common.h>
#include <rte_crypto.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_dev.h>
#include <rte_pci.h>

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn10k_cryptodev_ops.c
Expand Up @@ -3,7 +3,7 @@
*/

#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_event_crypto_adapter.h>
#include <rte_ip.h>

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn10k_cryptodev_ops.h
Expand Up @@ -6,7 +6,7 @@
#define _CN10K_CRYPTODEV_OPS_H_

#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

extern struct rte_cryptodev_ops cn10k_cpt_ops;

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn9k_cryptodev.c
Expand Up @@ -6,7 +6,7 @@
#include <rte_common.h>
#include <rte_crypto.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_dev.h>
#include <rte_pci.h>

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn9k_cryptodev_ops.c
Expand Up @@ -3,7 +3,7 @@
*/

#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_event_crypto_adapter.h>
#include <rte_ip.h>
#include <rte_vect.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cn9k_cryptodev_ops.h
Expand Up @@ -5,7 +5,7 @@
#ifndef _CN9K_CRYPTODEV_OPS_H_
#define _CN9K_CRYPTODEV_OPS_H_

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

extern struct rte_cryptodev_ops cn9k_cpt_ops;

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/cnxk/cnxk_cryptodev_ops.c
Expand Up @@ -3,7 +3,7 @@
*/

#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_errno.h>

#include "roc_cpt.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
Expand Up @@ -18,7 +18,7 @@
#include <rte_cycles.h>
#include <rte_kvargs.h>
#include <rte_dev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_common.h>
#include <rte_fslmc.h>
#include <fslmc_vfio.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/dpaa_sec/dpaa_sec.c
Expand Up @@ -12,7 +12,7 @@

#include <rte_byteorder.h>
#include <rte_common.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_crypto.h>
#include <rte_cryptodev.h>
#ifdef RTE_LIB_SECURITY
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/kasumi/rte_kasumi_pmd.c
Expand Up @@ -5,7 +5,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
#include <rte_cpuflags.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/kasumi/rte_kasumi_pmd_ops.c
Expand Up @@ -6,7 +6,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "kasumi_pmd_private.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/mlx5/mlx5_crypto.h
Expand Up @@ -8,7 +8,7 @@
#include <stdbool.h>

#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include <mlx5_common_utils.h>
#include <mlx5_common_devx.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/mvsam/rte_mrvl_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_security_driver.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
Expand Up @@ -8,7 +8,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_security_driver.h>

#include "mrvl_pmd_private.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/nitrox/nitrox_sym.c
Expand Up @@ -4,7 +4,7 @@

#include <stdbool.h>

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_crypto.h>

#include "nitrox_sym.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/null/null_crypto_pmd.c
Expand Up @@ -3,7 +3,7 @@
*/

#include <rte_common.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/null/null_crypto_pmd_ops.c
Expand Up @@ -6,7 +6,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "null_crypto_pmd_private.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/octeontx/otx_cryptodev.c
Expand Up @@ -5,7 +5,7 @@
#include <rte_bus_pci.h>
#include <rte_common.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_log.h>
#include <rte_pci.h>

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/octeontx/otx_cryptodev_ops.c
Expand Up @@ -5,7 +5,7 @@
#include <rte_alarm.h>
#include <rte_bus_pci.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_eventdev.h>
#include <rte_event_crypto_adapter.h>
#include <rte_errno.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/octeontx2/otx2_cryptodev.c
Expand Up @@ -6,7 +6,7 @@
#include <rte_common.h>
#include <rte_crypto.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_dev.h>
#include <rte_errno.h>
#include <rte_mempool.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/octeontx2/otx2_cryptodev_ops.c
Expand Up @@ -4,7 +4,7 @@

#include <unistd.h>

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_errno.h>
#include <rte_ethdev.h>
#include <rte_event_crypto_adapter.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/octeontx2/otx2_cryptodev_ops.h
Expand Up @@ -5,7 +5,7 @@
#ifndef _OTX2_CRYPTODEV_OPS_H_
#define _OTX2_CRYPTODEV_OPS_H_

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#define OTX2_CPT_MIN_HEADROOM_REQ 24
#define OTX2_CPT_MIN_TAILROOM_REQ 8
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/openssl/rte_openssl_pmd.c
Expand Up @@ -5,7 +5,7 @@
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_bus_vdev.h>
#include <rte_malloc.h>
#include <rte_cpuflags.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/openssl/rte_openssl_pmd_ops.c
Expand Up @@ -6,7 +6,7 @@

#include <rte_common.h>
#include <rte_malloc.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "openssl_pmd_private.h"
#include "compat.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_asym.h
Expand Up @@ -5,7 +5,7 @@
#ifndef _QAT_ASYM_H_
#define _QAT_ASYM_H_

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#include <rte_crypto_asym.h>
#include "icp_qat_fw_pke.h"
#include "qat_common.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_asym_pmd.c
Expand Up @@ -2,7 +2,7 @@
* Copyright(c) 2019 Intel Corporation
*/

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "qat_logs.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_sym.h
Expand Up @@ -5,7 +5,7 @@
#ifndef _QAT_SYM_H_
#define _QAT_SYM_H_

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#ifdef RTE_LIB_SECURITY
#include <rte_net_crc.h>
#endif
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_sym_hw_dp.c
Expand Up @@ -2,7 +2,7 @@
* Copyright(c) 2020 Intel Corporation
*/

#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>

#include "adf_transport_access_macros.h"
#include "icp_qat_fw.h"
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_sym_pmd.c
Expand Up @@ -7,7 +7,7 @@
#include <rte_dev.h>
#include <rte_malloc.h>
#include <rte_pci.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#ifdef RTE_LIB_SECURITY
#include <rte_security_driver.h>
#endif
Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/qat/qat_sym_session.h
Expand Up @@ -5,7 +5,7 @@
#define _QAT_SYM_SESSION_H_

#include <rte_crypto.h>
#include <rte_cryptodev_pmd.h>
#include <cryptodev_pmd.h>
#ifdef RTE_LIB_SECURITY
#include <rte_security.h>
#endif
Expand Down

0 comments on commit af66803

Please sign in to comment.