Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the generic "do no harm" question #70

Closed
wants to merge 2 commits into from
Closed

Conversation

Lucyeoh
Copy link
Contributor

@Lucyeoh Lucyeoh commented Jun 30, 2021

Changes proposed in this pull request:

Proposal to remove the generic "do no harm" question from the form on the assumption that the subsequent questions capture the relevant information required to evaluate whether the product was designed to avoid/mitigate harm.

Propagation of Changes

Identify where of the following the proposed changes need to be propagated, and include the relevant pull request where appropriate:

Lucyeoh and others added 2 commits June 30, 2021 14:55
Proposal to remove the generic "do no harm" question from the form on the assumption that the subsequent questions capture the relevant information required to evaluate whether the product was designed to avoid/mitigate harm.
@lacabra lacabra mentioned this pull request Jul 23, 2021
prajectory added a commit to DPGAlliance/publicgoods-scripts that referenced this pull request Oct 15, 2021
Updating quizQuestions.json, to reflect Changes accepted in [PR #70 DPGAlliance
/DPG-Standard repo](DPGAlliance/DPG-Standard#70) - Updating language of indicator 9 to read do no harm by design
@lacabra
Copy link
Contributor

lacabra commented Oct 15, 2021

@prajectory You are referencing this PR in your linked PRs above, but this PR is not approved, and it is superseded by #79. Thus I would argue that this should be closed without merging, and instead document the propagation of changes in #79 because you are actually propagating the changes proposed in that PR instead of this one 😉

@lacabra
Copy link
Contributor

lacabra commented Oct 15, 2021

@prajectory Also, I would argue that additional changes need to be propagated here and here in the submission form.

@prajectory prajectory closed this Oct 18, 2021
@prajectory prajectory reopened this Oct 18, 2021
@prajectory
Copy link
Contributor

Closing this pull request since the downstream issue is #79
We will execute the checklist there

@prajectory prajectory closed this Oct 18, 2021
@lacabra lacabra deleted the Lucyeoh-patch-3 branch October 18, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants