Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoded VIPS full submission into JSON #313

Merged
merged 10 commits into from
Feb 12, 2021
Merged

Conversation

nathanbaleeta
Copy link
Contributor

@nathanbaleeta nathanbaleeta commented Jan 27, 2021

Encoded VIPS full submission for becoming DPG into JSON.

Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathanbaleeta, everything looks good.

Based on the information provided, if this submissions makes for a successful screening of VIPS against the standard, kindly update the stage field from nominee to DPG in this same PR.

@nathanbaleeta
Copy link
Contributor Author

nathanbaleeta commented Feb 8, 2021

Thanks @nathanbaleeta, everything looks good.

Based on the information provided, if this submissions makes for a successful screening of VIPS against the standard, kindly update the stage field from nominee to DPG in this same PR.

@lacabra VIPS passes all the indicators except for their documentation which is still incomplete (work in progress) and last feedback from them indicated they would revert ASAP. Once they submit the updated documentation shall review and update their stage accordingly. Thanks.

@nathanbaleeta
Copy link
Contributor Author

Thanks @nathanbaleeta, everything looks good.
Based on the information provided, if this submissions makes for a successful screening of VIPS against the standard, kindly update the stage field from nominee to DPG in this same PR.

@lacabra VIPS passes all the indicators except for their documentation which is still incomplete (work in progress) and last feedback from them indicated they would revert ASAP. Once they submit the updated documentation shall review and update their stage accordingly. Thanks.

VIPS now provides a more complete documentationURL as shown in commit 26d901b and have proceeded to update the stage field from nominee to DPG in the same commit.

Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

@lacabra lacabra merged commit d487453 into master Feb 12, 2021
@lacabra lacabra deleted the vips-screening-json-encoding branch February 12, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants