Add nominee from impact tracker (remote sensors) #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I’ll update it
…On Tue, 6 Apr 2021 at 17:48, Nathan Baleeta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nominees/berkely-air-sums.json
<#409 (comment)>
:
> @@ -0,0 +1,40 @@
+{
+ "name": "Berkely Air Sums",
@ijeomaemeruwa <https://github.com/ijeomaemeruwa> kindly correct the
spelling for the name field to match the website
<https://berkeleyair.com/>. It appears to be Berkeley not Berkely. Please
clarify.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#409 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEPWEXOOD7F7ED6BX4BVODTHM3PTANCNFSM42OUN4QA>
.
|
|
Acknowledged. Thank you!
…On Tue, 6 Apr 2021 at 17:59, Nathan Baleeta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nominees/berkely-air-sums.json
<#409 (comment)>
:
> @@ -0,0 +1,40 @@
+{
+ "name": "Berkely Air Sums",
+ "description": "The Stove Use Monitoring System (SUMS) provides insights into cookstove usage patterns, number of meals cooked, and time of use by recording stove temperature changes. Data sampled by SUMS are uploaded to a computer via a data cable and further analyzed using proprietary algorithms developed to quantify cookstove usage in households.",
+ "website": "https://berkeleyair.com/",
+ "license": [
+ {
+ "spdx": "",
+ "licenseURL": ""
+ }
+ ],
+ "SDGs": [
+ {
+ "SDGNumber": 3,
+ "evidenceURL": "http://berkeleyair.com/about-us/mission/"
Instead of having all evidenceURLs point to the project's website, here
<https://cookstoves.lbl.gov/research/sums/> is an external link providing
evidence for SDG 3. @ijeomaemeruwa <https://github.com/ijeomaemeruwa>
kindly update this evidenceURL to use the above URL. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#409 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEPWEUQX5FLJ33YJQMSNUDTHM4YHANCNFSM42OUN4QA>
.
|
|
You may also want to fix the CI build that's failing before proceeding to push the requested changes. @ijeomaemeruwa consider running the following fixes:
|
|
@ijeomaemeruwa basing on the feedback shared, kindly iterate the requested changes to the remaining projects submitted. Thanks. |
4 tasks
|
Hello @nathanbaleeta @lacabra i have made the requested changes to the PR. I had to remove all nominees that didn't have an authorized license. Looking forward to you review. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32
Added nominees from Impact Tracker