Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DPG: Kiva Protocol #566

Merged
merged 10 commits into from
Jun 24, 2021
Merged

Add DPG: Kiva Protocol #566

merged 10 commits into from
Jun 24, 2021

Conversation

lacabra
Copy link
Contributor

@lacabra lacabra commented Jun 4, 2021

Complementary to #518

@lacabra lacabra mentioned this pull request Jun 4, 2021
Merged
nathanbaleeta
nathanbaleeta suggested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@nathanbaleeta nathanbaleeta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kiva Protocol needs to clarify the following indicators before we can proceed with reviewing them:

  • Clear Ownership
  • Documentation
  • Adherence to Privacy and Applicable Laws.
  • Do No Harm
  • Data Privacy & Security
  • Protection from harassment

@lacabra have contacted the person who made the submission and will update once they come through.

lacabra
lacabra commented Jun 22, 2021
View reviewed changes
Copy link
Contributor Author

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanbaleeta: looks good. Only a very minor change request.

digitalpublicgoods/kiva-protocol.json Outdated Show resolved Hide resolved
@lacabra
Copy link
Contributor Author

lacabra commented Jun 22, 2021

Ah, an update the status from nominee to DPG ;)

@nathanbaleeta
Copy link
Contributor

Ah, an update the status from nominee to DPG ;)

Resolved in commit cf9fde6

@lacabra
Copy link
Contributor Author

lacabra commented Jun 23, 2021

This looks good to me now, thanks for addressing the requested changes @nathanbaleeta

@nathanbaleeta nathanbaleeta merged commit f4acc90 into master Jun 24, 2021
@nathanbaleeta nathanbaleeta deleted the kiva branch June 24, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanbaleeta nathanbaleeta nathanbaleeta approved these changes

Assignees

@nathanbaleeta nathanbaleeta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacabra @nathanbaleeta