Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DPG: ICE (Immunization Calculation Engine, Issue #555) #659

Merged
merged 14 commits into from
Sep 8, 2021
Merged

Add DPG: ICE (Immunization Calculation Engine, Issue #555) #659

merged 14 commits into from
Sep 8, 2021

Conversation

ericherman
Copy link
Contributor

created with https://github.com/ericherman/dpg-csv-to-json - some cleanup may be desired.

See: #555 (comment)

@lacabra lacabra mentioned this pull request Jul 22, 2021
Closed
30 tasks
@nathanbaleeta nathanbaleeta self-assigned this Jul 28, 2021
@lacabra lacabra self-requested a review July 28, 2021 13:19
lacabra
lacabra suggested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two files in this PR, of which there should only be one.

Also, amend the nominee file to update the stage from nominee to DPG 😉

@ericherman
Copy link
Contributor Author

ericherman commented Jul 28, 2021 •
edited
Loading

There are two files in this PR, of which there should only be one.

Looks like a small oversight in 1a4adfa "Rename file to match nominee" - like maybe was done via a cp and git add forgetting the git rm (rather than doing a git mv) .... I questioned whether or not I should change the data in the name: field of this entry and decided that it was not my place to do so. I apologize for not being bolder.

lacabra
lacabra reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good other than the above question about the alias. Thanks @nathanbaleeta

nominees/immunization-calculation-engine.json Outdated Show resolved Hide resolved
@nathanbaleeta nathanbaleeta merged commit 9253a66 into DPGAlliance:main Sep 8, 2021
@ericherman ericherman deleted the ice branch March 28, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacabra lacabra lacabra approved these changes

@nathanbaleeta nathanbaleeta nathanbaleeta approved these changes

Assignees

@nathanbaleeta nathanbaleeta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericherman @lacabra @nathanbaleeta