Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nominee: Book Dash #862

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Update nominee: Book Dash #862

merged 5 commits into from
Nov 11, 2021

Conversation

lacabra
Copy link
Contributor

@lacabra lacabra commented Nov 5, 2021

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

@lacabra
Copy link
Contributor Author

lacabra commented Nov 5, 2021

@nathanbaleeta Please note that this should be merged with the existing nomination for bookdash (probably without the hyphen)

@nathanbaleeta
Copy link
Contributor

@nathanbaleeta Please note that this should be merged with the existing nomination for bookdash (probably without the hyphen)

Fixed in commit 058c627

@nathanbaleeta nathanbaleeta changed the title Add nominee: book-dash Update nominee: book-dash Nov 9, 2021
@nathanbaleeta nathanbaleeta changed the title Update nominee: book-dash Update nominee: Book Dash Nov 9, 2021
Copy link
Contributor Author

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@conradsp conradsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This submission looks good. @nathanbaleeta - agreed that we should rename this file and replace the existing bookdash.json file with this one

@nathanbaleeta nathanbaleeta merged commit f66f719 into main Nov 11, 2021
@nathanbaleeta nathanbaleeta deleted the bookdash-7dt2i2cr8e branch November 11, 2021 12:05
@nathanbaleeta nathanbaleeta mentioned this pull request Mar 4, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants