-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DPG: VaccineLedger #956
Conversation
Checklist for conducting technical review against DPG Standard:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feedback is summarized in two key points:
- We need to clarify the unlicensed repository included in their DPG submission (see my comment here).
- Do we consider their method of delivering documentation as best practices? To me, distributing PDFs embedded in a git repository is definitely not a best practice and decreases the accessibility of their documentation. I would want to push back some and encourage the team to adopt a tool to build a documentation site for their product, but curious for feedback from others more experienced in the review process than me.
According to the DPG standard, their existing documentation passes because it allows a technical person unfamiliar with the project to launch and run the software, hence any additions would help as recommendations not requirements to become a DPG. See indicator #5. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all pending feedback addressed.
Automatic addition of a new digital public good submitted through the online form available at https://digitalpublicgoods.net/submission