Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#368: Fix IT Tests Cleanup for Dev Database #369

Merged
merged 1 commit into from
Apr 3, 2021
Merged

#368: Fix IT Tests Cleanup for Dev Database #369

merged 1 commit into from
Apr 3, 2021

Conversation

DPigeon
Copy link
Owner

@DPigeon DPigeon commented Apr 3, 2021 •
edited
Loading

Related Issue

Proposed changes

  • Properly clean up the database when multiple users are added to it
  • Changed the order the entities are deleted when cleaning up (deleting from most recent created to last to properly delete the relationships)
  • No more bug where we create a user to test on dev and it gets deleted every time the IT tests are running

Additional Info

  • After the CI passes, I'll report if my user entity was indeed kept like it should normally.

Checklist (if applicable)

  • Tests (Tested on DEV and works, my user is not deleted anymore)

Reviewer(s)

  • BackendTeam

@DPigeon DPigeon self-assigned this Apr 3, 2021
@DPigeon DPigeon changed the title #368: Fix IT Tests Cleanup for Deb Database #368: Fix IT Tests Cleanup for Dev Database Apr 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DPigeon
Copy link
Owner Author

DPigeon commented Apr 3, 2021 •
edited
Loading

✔️ Note: the tests all executed (IT tests) and I can still see my user entity on the Dev Database. ✔️
Ready to be reviewed.

entity

EspressoCode
EspressoCode approved these changes Apr 3, 2021
View reviewed changes
Copy link
Collaborator

@EspressoCode EspressoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what we needed, removing relationships first and then removing the entities, good job David.

@DPigeon DPigeon linked an issue Apr 3, 2021 that may be closed by this pull request
IT Tests Cleanup Makes Dev Database Empty #368
Closed
@DPigeon DPigeon merged commit 419bb06 into dev Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EspressoCode EspressoCode EspressoCode approved these changes

@razine-bensari razine-bensari Awaiting requested review from razine-bensari

@abdulmansour abdulmansour Awaiting requested review from abdulmansour

@wltrf wltrf Awaiting requested review from wltrf

Assignees

@DPigeon DPigeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IT Tests Cleanup Makes Dev Database Empty
2 participants
@DPigeon @EspressoCode