Use the Prometheus exporter-toolkit #13
Conversation
|
Hey @DRuggeri, just checking on this oull. Should it be updated to the latest exporter-toolkit verison? |
|
Stumbling across this looking into an thing where the exporter does not seem to do any verification of client tls certs. Pretty sure that the exporter toolkit handles that fine. |
SuperQ
force-pushed
the
exporter-toolkit
branch
from
660ae7b
to
6b977a3
Compare
Use the Prometheus exporter-toolkit web package to handle TLS and basic auth configuration. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
exporter-toolkit
branch
from
6b977a3
to
05ab5fc
Compare
There was a problem hiding this comment.
@SuperQ looks like the Go version needs to be updated for some CI steps.
|
Yea, I need to double check this patch. I don't actually use NUT anymore, so I have no way to test this. |
Assuming you still have it installed somewhere there is the dummy UPS for testing: https://networkupstools.org/docs/man/dummy-ups.html I have used it a few times specifically to test monitoring/alerts. |
I'm down to test on my home lab setup ... |
|
@otakup0pe CI build is not working yet but if you checkout @SuperQ's branch |
|
Recently my suggestion to enhance the toolkit was rejected which leaves this exporter in a difficult spot: implement a breaking change for users (some CLI arguments and env variables that work today would no longer work). Happy to take a look at #32 since that may be a bug or gap, but I don't wish to force a breaking change on users without some sort of clear benefit to them. |
|
Anyway, sorry, I don't have time to complete this work. I don't use NUT anymore, so not much interest in more work here. |
|
@otakup0pe and @DaAwesomeP - FYI, this still lives in branch PR-13 I'll fold these updates in to add support for TLS client auth as mentioned in #32 but have a PR out to improve doco on the toolkit before including |
Use the Prometheus exporter-toolkit web package to handle TLS and basic
auth configuration.
Signed-off-by: SuperQ superq@gmail.com