Add additional comments to the summary page #28
Conversation
This class was written for another Nava project, and can be useful for us to build off in order to produce USWDS form styling. In order to get the tests running, I had to bring in Capybara, which seems okay since we will probably want to use it soon for integration testing anyway.
* Adds a form field to the "summary" page that prompts the user if they had any other information that would affect the income figures * The data is stored in a new column on `CbvFlow` model: `additional_information` * Move the "Download PDF" and "Send to Caseworker" buttons to a new page called "share" (since, when submitting a form, the user will need a different page to land on). * Unrelatedly, change some i18n strings to use relative paths rather than absolute paths.
| if request.patch? | ||
| @cbv_flow.update(summary_update_params) | ||
| return redirect_to next_path | ||
| end |
There was a problem hiding this comment.
This makes sense but soon we might need to start splitting this out into multiple controllers
There was a problem hiding this comment.
Agreed. This is officially getting to be Too Much™. I've got an idea for it. I'll make a task for it.
There was a problem hiding this comment.
broken out into: https://jiraent.cms.gov/browse/FFS-807
There was a problem hiding this comment.
Fabulous... it's too bad Nava doesn't have this published as gem or something. Wonder if we could separate it into a local gem folder? I don't feel too strongly about that, just a thought.
Separately, though, does this need to be applied to the employer search form, too? Would love to use the same FormBuilder. And would like to see that it works with the Hotwire feature.
There was a problem hiding this comment.
Gem would be cool, agreed, but not much return on investment unless a second team wants to actively use it. And yeah, probably should use it for the employer search. I just asked in #engineering.
| @@ -0,0 +1,14 @@ | |||
| <h2> | |||
| <%= t('.header') %> | |||
There was a problem hiding this comment.
Love the relative dot paths
Add additional comments to summary page
Fixes FFS-771.
Solution
This class was written for another Nava project, and can be useful for
us to build off in order to produce USWDS form styling. In order to get
the tests running, I had to bring in Capybara, which seems okay since we
will probably want to use it soon for integration testing anyway.
had any other information that would affect the income figures
CbvFlowmodel:additional_informationpage called "share" (since, when submitting a form, the user will need
a different page to land on).
than absolute paths.
Result
Test Plan
Unit/controller tests included.