FFS-984: Missing Results Page #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdooner
reviewed
Jul 1, 2024
| > | ||
| <%= t('cbv.employer_searches.show.search_by_payroll_provider') %> | ||
| </button> | ||
| <%= link_to 'missing_results', data: { turbo_frame: "_top" } do %> |
There was a problem hiding this comment.
Does link_to 'missing_results' work? Never seen that syntax before (but Rails contains multitudes, so I legit don't know).
I would have expected:
link_to cbv_flow_missing_result_path, [...]
There was a problem hiding this comment.
Thanks. Updated the PR to use this method
| <button | ||
| data-id="" | ||
| data-response-type="" | ||
| class="usa-button usa-button--outline" |
There was a problem hiding this comment.
I think we should just apply these classes to the <a> tag rather than having a button in a link.
e.g. link_to [...], class: "usa-button usa-button--outline"
There was a problem hiding this comment.
Switch it to be an anchor link
allthesignals
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-984
Changes
Context for reviewers
NOTE: This should be reviewed after #78.
There is a link to the "agency site". I used https://www.cms.gov but open to suggestions.
Testing
Screenshots