Add ErbLint for view linting #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthesignals
approved these changes
Jul 2, 2024
Ruby is universally 2-space indent. This commit enables the linter for that and also the linter to ensure there is no indent after `private` or `protected` access modifiers.
tdooner
force-pushed
the
td/improve-linters
branch
from
aeff119
to
ebeac0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A - I realized we should do these when giving Joe some CR feedback.
Changes
Context for reviewers
Erblint is the standard way to lint Erb views. I've disabled the SpaceInHtmlTag linter because it forbids putting the close angle bracket on the subsquent line, e.g.:
Personally, I find that more readable than if the
>were on the same line asattribute="value".Testing
It should run as part of this PR.