Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable pylints' invalid name rule C0103 #1461

Conversation

dominik003
Copy link
Collaborator

@dominik003 dominik003 commented Mar 26, 2024

This PR enables pylints' invalid-name rule, i.e., C0130 and fixes resulting issues. One issue was properly fixed by changing constant enum fields to uppercase and two other issues were simply ignored. The first ignored issue, i.e., the naming problem of T4CRepositoriesResponseModel is not compliant due to the two directly preceding capital letters CR, which is intended here. The second problem is a false positive, since pod_security_context is considered a constant, but there are two places where we assign it a value, i.e., it is not actually constant.

Resolves #1379

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (b3a7f8f) to head (61e7290).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat-add-mccabe-complexity-check    #1461   +/-   ##
=================================================================
  Coverage                             76.48%   76.48%           
=================================================================
  Files                                   170      170           
  Lines                                  5665     5665           
  Branches                                649      649           
=================================================================
  Hits                                   4333     4333           
  Misses                                 1183     1183           
  Partials                                149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit e0f83d8 into feat-add-mccabe-complexity-check Mar 26, 2024
13 checks passed
@MoritzWeber0 MoritzWeber0 deleted the feat-enable-pylint-invalid-name-rule branch March 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants