Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated attributes #434

Open
ewuerger opened this issue Jul 2, 2024 · 2 comments
Open

Remove duplicated attributes #434

ewuerger opened this issue Jul 2, 2024 · 2 comments

Comments

@ewuerger
Copy link
Collaborator

ewuerger commented Jul 2, 2024

We need to finally remove the .functions attribute on Components because there is allocated_functions. The same for realized_components. There is somehow realized_logical_components which is the exact same. Duplicated information should go from the API. Let's investigate the public API.

@ewuerger ewuerger self-assigned this Jul 2, 2024
@Wuestengecko
Copy link
Member

Most of these dups are already deprecated anyways and so will be removed with the next major bump anyways. As for the ones that aren't, I was planning on looking through this at some not-so-distant point as well and adding deprecation markers there too.

Is there any reason to remove them now? You're making it sound somewhat urgent.

@ewuerger
Copy link
Collaborator Author

ewuerger commented Jul 3, 2024

Displaying attributes on various model elements in the capella model explorer is a default feature. With the duplication of attributes under different names comes confusion and a bloated view for the user. It also displays the ambiguity in capellambse's API. Implementing templates for model elements in the model explorer should be seen as a chance to refine the public API of capellambse. :)

The ones I enumerated are just the attributes that I know of for quite a while. The deprecation warning probably, I'm not completely sure here, lasted for quite some time.

The additional logic for filtering the duplicated attributes out (needs to be assessed individually on every model element type) can be spared when it is just removed here. The effect: A cleaner appearance and more concise information of model elements in the model explorer views.

Wuestengecko added a commit that referenced this issue Jul 11, 2024
This helps a bit with the issue described in #434.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants