Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean tests #96

Open
ewuerger opened this issue Jun 7, 2022 · 0 comments
Open

Clean tests #96

ewuerger opened this issue Jun 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ewuerger
Copy link
Collaborator

ewuerger commented Jun 7, 2022

  • Remove unused test models and merge test models into latest version
  • Apply Pytest best practices
  • Either add logic into SVG tests or remove them

IMO it would be better to add this to the 5.0 test model, instead of adding some cases to the 5.2 one. Keeping as much as possible in the same model will make it easier to migrate to a higher minimum supported version in the future, because there's only one model with actual useful content.

Originally posted by @Wuestengecko in #94 (comment)

@ewuerger ewuerger added enhancement New feature or request good first issue Good for newcomers labels Jun 7, 2022
@Wuestengecko Wuestengecko removed the good first issue Good for newcomers label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants