Run Aird parser tests on all platforms #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both render diagrams slightly different, resulting in just enough variance to make the tests fail on either of the platforms. This test is pretty high-over. I considered it's better to run them on both platforms with different expected output, than to not run them at all.
The git handler requires git-lfs.
amolenaar
force-pushed
the
fix/aird_parser_tests
branch
from
183ca10
to
d348c92
Compare
|
Partly merged: aird tests are considered broken, so this commit has been left out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aird parser tests currently only run on Windows.
This PR adds the ability to test the parser and serializer on linux (working on macOS).
Although we should re-evaluate the value of those tests, having them running on all platforms is an improvement.