Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1155: trainspace endpoints #1158

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

ssh51117
Copy link
Collaborator

Add new trainspace table endpoints with unit tests

Github Issue Number Here: #1155
What user problem are we solving?
We changed the format of the DyanmoDB tables, but the API endpoints do not reflect that.
What solution does this PR provide?
Added the endpoints with unit tests to ensure functionality. Also migrated from using lib-dynamodb to client-dynamodb to remove extra layer of unnecessary abstraction
Testing Methodology

How did you test your changes and verify that existing functionality is not broken
Added and verified unit tests, and used postman to ensure functionalitly is not broken:
https://youtu.be/qxAbrPGJ2kQ
Any other considerations
need to update user table to follow new conventions in the code (using @aws-sdk/client-dynamodb only) and unit tests (suppressing errors)

@ssh51117 ssh51117 requested a review from a team as a code owner April 10, 2024 03:04
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@codingwithsurya codingwithsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssh51117 ssh51117 added this pull request to the merge queue Apr 10, 2024
Merged via the queue into nextjs with commit d7db5f3 Apr 10, 2024
4 checks passed
@ssh51117 ssh51117 deleted the feature-1155-trainspace-endpoints branch April 10, 2024 03:20
Copy link
Contributor

@alantao912 alantao912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants