1. fixing q-type leak 2. tweaks to run with Pytroch 1.x #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the great repository!
However, I found that for QA type classification, the code includes the sub-type into the training/testing data. Needless to say it's a perfect predictor. So, I am fixing this, plus make a couple of tweaks to make it compatible with the latest Python.
I couldn't get rid of the annoying GenSim warning, but maybe you'll have more luck if you re-run the notebook.
Predictably, after removing the leak the accuracy drops. However, I verified that with ALL the data, it goes up again, at least when you randomly sample 10% from the training set to be test data. Maybe, the numbers will be different if you use the official test set. However, you data download script does not download all the data, so I kept this whole thing as is.
BTW, it takes only a few seconds to train on a MacBook pro (and a couple of minutes on all the data). Not long at all!