Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FileA routine to read dates with 4-digit year #406

Merged
merged 10 commits into from Apr 26, 2024

Conversation

thiagoferreira53
Copy link
Contributor

The code was tested but it would be good if more people could test the modifications using their data;

The code requires that all columns in the fileA are right aligned

Observations:

  • LUGO9301.SBX has different values in the EVALUATE.OUT for PDFPM since the fileA has PDFT and R5AT with different values;

  • GHNY9801.PNA columns are not properly aligned there the ADAPM is not showing;

@fabiooliveira72
Copy link
Contributor

@thiagoferreira53!

Compile failed for IFORT. Please check the line endings for SG_OPHARV.for:
See below:

C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(438): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(440): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(444): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(447): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(449): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(452): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(454): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(456): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(458): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(460): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(462): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(464): error #5082: Syntax error, found END-OF-STATEMENT when expecting one of: :: ) , :
C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for(338): warning #8889: Explicit interface or EXTERNAL declaration is required. [READA_Y4K]
compilation aborted for C:\Users\fabioaug.antunes\Desktop\CODE-REVIEW\dssat-csm-os-fileA_reads\Plant\CERES-Sorghum\SG_OPHARV.for (code 1)

@thiagoferreira53
Copy link
Contributor Author

Thanks Fabio. It should work now.

@fabiooliveira72
Copy link
Contributor

fabiooliveira72 commented Apr 19, 2024

@thiagoferreira53!

All good now. System test done and no differences.

Thanks for your contribution to the dssat-csm-os repository. I wish you a good weekend and stay safe!

@fabiooliveira72 fabiooliveira72 merged commit f65fc5c into DSSAT:develop Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants